fix(TextArea) missing props and auto resize example doesn't work as intended#7947
Merged
tlabaj merged 1 commit intopatternfly:mainfrom Sep 9, 2022
Merged
fix(TextArea) missing props and auto resize example doesn't work as intended#7947tlabaj merged 1 commit intopatternfly:mainfrom
tlabaj merged 1 commit intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-7947.surge.sh A11y report: https://patternfly-react-pr-7947-a11y.surge.sh |
a8e156b to
7d8b2e6
Compare
thatblindgeye
approved these changes
Sep 7, 2022
tlabaj
reviewed
Sep 7, 2022
Contributor
tlabaj
left a comment
There was a problem hiding this comment.
Looks good. It may be worth adding a unit test for this one.
kmcfaul
approved these changes
Sep 8, 2022
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Contributor
Author
I am going to add the unit test as part of TextArea test revamp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #7834